[COM-28756]: update scarcity #45
Conversation
| <div class="product-scarcity" data-variant-attributes="{"Color":"Red"}" hidden> | ||
| Only 3 left! | ||
| </div> | ||
| <div class="product-scarcity" data-variant-attributes="{"Color":"Red"}" hidden> |
There was a problem hiding this comment.
I am not sure why spacing matters. Some tests are failing and I am not sure why. There might be extra spacing or invisible character I am missing?
There was a problem hiding this comment.
The language is whitespace-sensitive, so the output needs to match whitespace as well.
There was a problem hiding this comment.
@phensley I am not sure what I'm missing here. Appreciate any help with this!
There was a problem hiding this comment.
@sizhang12 I'll take a look shortly
There was a problem hiding this comment.
@phensley thank you! I will be making the same changes into template-engine as well.
|
@sizhang12 Please update the commit message to include the full description of the change. |
phensley
force-pushed
the
om/COM-28756-product-scarcity-update
branch
from
d2d95a6
to
daae93e
Compare
|
This change is released in version |
Updating scarcity to include rendering the total scarcity amount when
scarcityShownByDefaultis true but also rendering the scarcity with attributes after.If
scarcityShownByDefaultis true, then that means the first index ofscarcityTemplateViewsis the total stock. Everything after that are by variants with attributes.