[COM-28756]: product scarcity update #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparksqsp
approved these changes
Jul 31, 2023
Update product-scarcity formatter to render without attributes on the first index if scarcityShowByDefault is true and render the rest with or without attributes. Also added + updated scarcity test cases
phensley
force-pushed
the
om/COM-28756-product-scarcity-update
branch
from
fc048ce
to
e42311a
Compare
phensley
approved these changes
Jul 31, 2023
|
This change is released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates product-scarcity formatter to show the first index scarcity without attributes based on a boolean value. Rest of the scarcity will render with or without attributes. The same changes have been made to template-compiler: Squarespace/template-compiler#45