audible feedback #15
Open
audible feedback #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove unecessary files
| <package format="3"> | ||
| <name>autonav_hardware</name> | ||
| <version>0.0.0</version> | ||
| <description>TODO: Package description</description> |
There was a problem hiding this comment.
version 2025.0.1 (or .1.0, whichever you prefer) and package description
| 20 | ||
| ) | ||
|
|
||
| self.system_state_monitor = self.create_timer(0.5, self.monitor_system_state) |
There was a problem hiding this comment.
SystemStateTransition might get implemented this year, TBD, so you might be able to change this in the future
| def on_audible_feedback_received(self, msg:AudibleFeedback): | ||
| self.monitor_tracks() | ||
|
|
||
| self.log(f"{len(self.tracks)}", LogLevel.ERROR) |
There was a problem hiding this comment.
change to LogLevel.DEBUG before merging so no red ERROR color jumpscares
|
|
||
| def play_sound(self, filename): | ||
| playback = Playback() | ||
| playback.load_file(filename) |
There was a problem hiding this comment.
if this file doesn't exist does this fail gracefully or crash the code? if it crashes a try/catch would be nice, otherwise no problems, although doing some processing on the file name (like a .strip() maybe) might be worth it?
…use buttons to controller dpad, and secondary tracks example to controllre X button
danielbrownmsm
approved these changes
Dec 10, 2024
| audible_feedback.pause_all = True | ||
| self.audibleFeedbackPublisher.publish(audible_feedback) | ||
|
|
||
| if self.controller_state['abs_hat0x'] == 1: |
There was a problem hiding this comment.
could be an elif instead of an if but no biggie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will play audio files sent in an AudibleFeedback message.
AudibleFeedback message also contains a field which if True will stop all currently playing tracks.