Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[review] [email protected], [email protected] #150

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[review] [email protected], [email protected] #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0fdbc
feat: [email protected], [email protected]
aki77 Sep 19, 2023
168d847
0.10.9
aki77 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sgcop/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Sgcop
VERSION = '0.10.8'.freeze
VERSION = '0.10.9'.freeze
end
13 changes: 13 additions & 0 deletions rails/rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,3 +574,16 @@ FactoryBot/FactoryAssociationWithStrategy: # new in 2.23
# https://docs.rubocop.org/rubocop/cops_factorybot.html#factorybotredundantfactoryoption
FactoryBot/RedundantFactoryOption: # new in 2.23
Enabled: true
# https://docs.rubocop.org/rubocop/cops_factorybot.html#factorybotidsequence
FactoryBot/IdSequence: # new in <<next>>
Enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

違ったパターンのURLになってるな。
スクリプトの対応せねば。
https://docs.rubocop.org/rubocop-factory_bot/cops_factorybot.html#factorybotidsequence

factory_bot に id を書くことはそうそうなさそうだけどな。


# https://docs.rubocop.org/rubocop/cops_capybara.html#capybaraclicklinkorbuttonstyle
Capybara/ClickLinkOrButtonStyle: # new in 2.19
Enabled: false
Comment on lines +581 to +583
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これもドキュメントのURLが違う。
https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle

全体的にURLが変わったとかだろうか？

# https://docs.rubocop.org/rubocop/cops_capybara_rspec.html#capybararspechaveselector
Capybara/RSpec/HaveSelector: # new in 2.19
Enabled: false
# https://docs.rubocop.org/rubocop/cops_capybara_rspec.html#capybararspecpredicatematcher
Capybara/RSpec/PredicateMatcher: # new in 2.19
Enabled: true
4 changes: 2 additions & 2 deletions sgcop.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']

spec.add_dependency 'rubocop', '~> 1.56.0'
spec.add_dependency 'rubocop-capybara', '~> 2.18.0'
spec.add_dependency 'rubocop-factory_bot', '~> 2.23.1'
spec.add_dependency 'rubocop-capybara', '~> 2.19.0'
spec.add_dependency 'rubocop-factory_bot', '~> 2.24.0'
spec.add_dependency 'rubocop-performance', '~> 1.19.0'
spec.add_dependency 'rubocop-rails', '~> 2.21.0'
spec.add_dependency 'rubocop-rake', '~> 0.6.0'
Expand Down