[review] [email protected], [email protected] #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunichi
approved these changes
Sep 21, 2023
| @@ -574,3 +574,16 @@ FactoryBot/FactoryAssociationWithStrategy: # new in 2.23 | |||
| # https://docs.rubocop.org/rubocop/cops_factorybot.html#factorybotredundantfactoryoption | |||
| FactoryBot/RedundantFactoryOption: # new in 2.23 | |||
| Enabled: true | |||
| # https://docs.rubocop.org/rubocop/cops_factorybot.html#factorybotidsequence | |||
| FactoryBot/IdSequence: # new in <<next>> | |||
| Enabled: true | |||
There was a problem hiding this comment.
違ったパターンのURLになってるな。
スクリプトの対応せねば。
https://docs.rubocop.org/rubocop-factory_bot/cops_factorybot.html#factorybotidsequence
factory_bot に id を書くことはそうそうなさそうだけどな。
Comment on lines
+581
to
+583
| # https://docs.rubocop.org/rubocop/cops_capybara.html#capybaraclicklinkorbuttonstyle | ||
| Capybara/ClickLinkOrButtonStyle: # new in 2.19 | ||
| Enabled: false |
There was a problem hiding this comment.
これもドキュメントのURLが違う。
https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle
全体的にURLが変わったとかだろうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.