Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a M73 and layer number regression s #8435

Conversation

SoftFever
Copy link
Owner

@SoftFever SoftFever commented Feb 17, 2025

Description

Fixed two regressions:

  1. Total layer number was missing for BBL printers
  2. M73 remaining info was wrong when ARC fitting is enabled.

Screenshots/Recordings/Graphs

Tests

@Schildkroet
Copy link
Contributor

Printing time is still wrong. After 50-60% it already shows 100% and no remaining time.
Try slicing a model with >4h print time and search for "M73 P100 R0" in gcode. It will already appear between 50-60% of pruduced gcode

@Schildkroet
Copy link
Contributor

Here is an example of my test:
100% is first reported on line 540719:
image

But my file has over 1M lines of code
image

@SoftFever
Copy link
Owner Author

Here is an example of my test: 100% is first reported on line 540719

Hmm, it works fine here. can you try the attached project?
Or share the your project?
m73.zip

@Schildkroet
Copy link
Contributor

M73_Test.zip

@SoftFever SoftFever changed the title Fix a regression that total layer number is missign for BBL printers Fix a M73 and layer number regression s Feb 18, 2025
@SoftFever
Copy link
Owner Author

M73_Test.zip

👍
Thank you.
It should be fixed now(for real XD)

@Schildkroet
Copy link
Contributor

First test looks good. Will do some actual print tests later to confirm everything.

@SoftFever
Copy link
Owner Author

First test looks good. Will do some actual print tests later to confirm everything.

Appreciate it!

@Schildkroet
Copy link
Contributor

Print tests were also successfull 👍

@SoftFever SoftFever merged commit 98b396c into main Feb 19, 2025
16 checks passed
@SoftFever SoftFever deleted the feature/fix_regression-that-total-layer-is-missing-for-BBL-printers branch February 19, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants