Solve M73 issue: remove TimeProcessor::post_process #8425
Conversation
|
This version does not include maximum layers. It always says 0 |
| } | ||
| //BBS: write total layer number | ||
| else if (line == reserved_tag(ETags::Total_Layer_Number_Placeholder)) { | ||
| char buf[128]; |
There was a problem hiding this comment.
This part is needed.
👍 Nice catch!
We need to incorporate this logic into the GCodeProcessor::run_post_process() function.
It is quite late where I am, so I’ll review this tomorrow or on another day.
Thank you for tracking the issue all the way down!
There was a problem hiding this comment.
No problem. Just my feedback to help improving Orca Slicer
|
The time calcualtion is now also wrong. My 3h print was at 100% after 2h. |
It should be fix in #8435 now. Tested on P1S |
Description
ref to: #8388
Screenshots/Recordings/Graphs
Tests