Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove task actions #998

Merged
merged 1 commit into from
Oct 18, 2024
Merged

remove task actions #998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions skyvern/forge/sdk/db/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,3 +1629,15 @@ async def get_previous_actions_for_task(self, task_id: str) -> list[Action]:
)
actions = (await session.scalars(query)).all()
return [Action.model_validate(action) for action in actions]

async def delete_task_actions(self, organization_id: str, task_id: str) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling for SQLAlchemyError and other exceptions, similar to other methods in this class, to ensure consistent error logging and handling.

async with self.Session() as session:
# delete actions by filtering organization_id and task_id
stmt = delete(ActionModel).where(
and_(
ActionModel.organization_id == organization_id,
ActionModel.task_id == task_id,
)
)
await session.execute(stmt)
await session.commit()
Loading