remove task actions #998
remove task actions #998
Conversation
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add deletion of task actions when nuking and restarting a task in `cloud/tasks.py`. > > - **Behavior**: > - `nuke_related_objects_for_task` in `cloud/tasks.py` now deletes task actions before resetting task status. > - **Database**: > - Adds `delete_task_actions` method in `client.py` to delete actions by `organization_id` and `task_id`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 2874fb66c2f591b62fa671bc17cabed864e2837a. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 97b56ff in 10 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_353NTnrl26Ef63Zt
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 97b56ff in 21 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_II9yOBS6CYJ2C22A
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -1629,3 +1629,15 @@ async def get_previous_actions_for_task(self, task_id: str) -> list[Action]: | |||
| ) | |||
| actions = (await session.scalars(query)).all() | |||
| return [Action.model_validate(action) for action in actions] | |||
|
|
|||
| async def delete_task_actions(self, organization_id: str, task_id: str) -> None: | |||
There was a problem hiding this comment.
Consider adding error handling for SQLAlchemyError and other exceptions, similar to other methods in this class, to ensure consistent error logging and handling.
wintonzheng
changed the title
Important
nuke_related_objects_for_taskincloud/tasks.pynow deletes task actions using the newdelete_task_actionsmethod inclient.py.nuke_related_objects_for_taskincloud/tasks.pynow deletes task actions before resetting task status.delete_task_actionsmethod inclient.pyto delete actions byorganization_idandtask_id.This description was created by
for 97b56ff. It will automatically update as commits are pushed.