Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardsuit Walking Sounds And Refactor EmitSoundOnMove #1698

Merged
merged 5 commits into from
Feb 1, 2025

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Feb 1, 2025

Description

Thanks to MajorMoth for making these sound effects! This PR adds custom sound effects to Hardsuits & Tacsuits that are generated when the wearer moves. However while making this PR, I ran into three different bugs with the EmitSoundOnMoveSystem, so I fixed all 3 of them!

TODO

Media

hardsuit.sounds.mp4

Changelog

🆑 VMSolidus and MajorMoth

  • add: Hardsuits now have sounds made when the wearer moves!
  • fix: Fixed several bugs with EmitSoundOnMove. It no longer plays the same sound 7 times in a row for the client. It can now differentiate between items that must be worn to make sounds and otherwise. It can also have variable distance needed to travel to make a sound.
  • add: Hardsuits and Tacsuits are now separated into Light, Medium, and Heavy categories, with each category having its own sound effects, mass, throwing statistics, and don/doff time. Most hardsuits are Light. Most Tacsuits are Medium. Some suits like Warden, Juggernaut, Nukie Commander, and Mysta Bombsuit are heavy.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files Changes: Audio Changes any ogg files Status: Needs Review Someone please review this labels Feb 1, 2025
@VMSolidus
Copy link
Member Author

We now have Light, Medium, and Heavy hardsuits, with different sounds for each.

@VMSolidus VMSolidus merged commit cdf8468 into Simple-Station:master Feb 1, 2025
11 of 12 checks passed
SimpleStation14 added a commit that referenced this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants