Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Specie Name #1120

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

Aidenkrz
Copy link
Contributor

@Aidenkrz Aidenkrz commented Oct 21, 2024

Description

Custom specie name wouldn't properly update when a different race was selected, or when you changed profiles.
This fixes that.
Also makes it so the text field is automatically filled with the default name instead of an empty space.
(and makes the species check less bad 😺 )

Solves #1101


Media

https://gyazo.com/63ba2d8a3456c19c70f25164ae42078d


Changelog

🆑

  • fix: Custom specie name doesn't disappear in the editor anymore.

@Aidenkrz Aidenkrz marked this pull request as ready for review October 21, 2024 00:47
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Oct 21, 2024
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love wizden PR, making a mess, good job tho

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love string fuckery so much. Wack.

@VMSolidus VMSolidus merged commit ec31b11 into Simple-Station:master Oct 22, 2024
11 checks passed
Remuchi pushed a commit to Remuchi/Einstein-Engines that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants