Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Species Name disappears after switching race, when disabled in the prototype #1101

Closed
DangerRevolution opened this issue Oct 19, 2024 · 5 comments
Closed

Custom Species Name disappears after switching race, when disabled in the prototype #1101

DangerRevolution opened this issue Oct 19, 2024 · 5 comments
Labels
Type: Bug [Un]intentional issue with something

Comments

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Oct 19, 2024 •
edited
Loading

Reproduction

Enter the Character UI
Swap race

Expected behavior

It doesn't do that

Media

2024-10-19.22-25-07.mp4

This happens whether or not you input any text.
This does not return if you restart the round, nor re-enter the lobby. You have to full restart to get the menu back.
@DangerRevolution DangerRevolution added the Type: Bug [Un]intentional issue with something label Oct 19, 2024
@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Oct 19, 2024 •
edited
Loading

Yes, this was also a problem in dde6130 (changelog commit after #994). Not sure how this passed review given this is findable within 5 seconds of interacting with the menu.

@FoxxoTrystan
Copy link
Contributor

Reproduction

Enter the Character UI Swap race

Expected behavior

It doesn't do that

Media

2024-10-19.22-25-07.mp4
This happens whether or not you input any text. This does not return if you restart the round, nor re-enter the lobby. You have to full restart to get the menu back.

Custom Specie Name menu should be visible to begin with, as goob MRP (if i think this is where its from) did not enable those.

The name should not show up actully unless enabled, did you enable the CustomName variable?

@DangerRevolution DangerRevolution changed the title Custom Species Name disappears after switching race Custom Species Name disappears after switching race, when disabled in the prototype Oct 20, 2024
@DangerRevolution
Copy link
Contributor Author

I found the problem; surprisingly the species prototypes aren't validated. I've renamed the issue to be more accurate.

@Aidenkrz Aidenkrz mentioned this issue Oct 21, 2024
Merged
VMSolidus pushed a commit that referenced this issue Oct 22, 2024
@Aidenkrz
Fix Custom Specie Name (#1120)
ec31b11 
# Description

Custom specie name wouldn't properly update when a different race was
selected, or when you changed profiles.
This fixes that.
Also makes it so the text field is automatically filled with the default
name instead of an empty space.
(and makes the species check less bad 😺 )

Solves #1101

---

<details><summary><h1>Media</h1></summary>
<p>

https://gyazo.com/63ba2d8a3456c19c70f25164ae42078d

</p>
</details>

---

# Changelog

:cl:
- fix: Custom specie name doesn't disappear in the editor anymore.
@Aidenkrz
Copy link
Contributor

This should be fixed now

@sapphirescript
Copy link
Contributor

This was fixed in #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug [Un]intentional issue with something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Aidenkrz @angelofallars @FoxxoTrystan @sapphirescript @DangerRevolution