Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes issue #435: 🐛 Fix tap issue for days not in month #440

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix: Fixes issue #435: 🐛 Fix tap issue for days not in month #440

merged 2 commits into from
Jan 2, 2025

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Jan 2, 2025 •
edited
Loading

Description

  • Fixed tap issue: If hideDaysNotInMonth: true in month view then in default filled cell onTileDoubleTap & onTileLongTap is not working.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Related issue: #435

@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/taps_in_month_view branch 2 times, most recently from 118a4bb to 35e015a Compare January 2, 2025 08:03
@shubham-jitiya-simform shubham-jitiya-simform changed the title fix: Fixes issue #435: ✨Fix tap issue for days not in month fix: Fixes issue #435: 🐛 Fix tap issue for days not in month Jan 2, 2025
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review January 2, 2025 11:24
PRBaraiya
PRBaraiya approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 6cba477 into master Jan 2, 2025
1 check passed
@shubham-jitiya-simform shubham-jitiya-simform mentioned this pull request Jan 3, 2025
Open
@PRBaraiya PRBaraiya deleted the fix/taps_in_month_view branch January 31, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham-jitiya-simform @PRBaraiya