inconsistency in MonthView

[bsutton]

The DayView and the WeekView both have a 'backgroundColor' argument however the MonthView doesn't.

I'm trying to display the calendar in dark mode hence the requirement to sent the background color to black.

[shubham-jitiya-simform]

Hi @bsutton,
In month view you can use FilledCell which has backgroundColor property or return your own custom widget.
For dark theme support refer PR #431

Please refer this default cell builder

  Widget _defaultCellBuilder(
    date,
    List<CalendarEventData<T>> events,
    isToday,
    isInMonth,
    hideDaysNotInMonth,
  ) {
    if (hideDaysNotInMonth) {
      return FilledCell<T>(
        date: date,
        shouldHighlight: isToday,
        backgroundColor: isInMonth ? Constants.white : Constants.offWhite,
        events: events,
        isInMonth: isInMonth,
        onTileTap: widget.onEventTap,
        dateStringBuilder: widget.dateStringBuilder,
        hideDaysNotInMonth: hideDaysNotInMonth,
      );
    }
    return FilledCell<T>(
      date: date,
      shouldHighlight: isToday,
      backgroundColor: isInMonth ? Constants.white : Constants.offWhite,
      events: events,
      onTileTap: widget.onEventTap,
      onTileLongTap: widget.onEventLongTap,
      dateStringBuilder: widget.dateStringBuilder,
      onTileDoubleTap: widget.onEventDoubleTap,
      hideDaysNotInMonth: hideDaysNotInMonth,
    );
  }

[bsutton]

thanks for the prompt response. so I can see how that works now. I would however again argue that there appears to be no reason for an alternate api for the month vs week/day. It would appear that a more consistent api could be created that has a common method for styling the 'visual regions' of each view. It feels like the api design for the month view got a little too tightly linked to the underlying grid implementation. The current implementation also means that I have to reproduce the default cell builder to just override the background colour. The api would be easier to customise if it allowed a user to fully customise the styles without having to rebuild the layout. Like the headerstyle it feels like there should be a body/region style that allows the user to customise the font/background etc independently of the layout. my two cents worth.

…

On Mon, Dec 30, 2024 at 8:13 PM shubham-jitiya-simform < ***@***.***> wrote: Hi @bsutton <https://github.com/bsutton>, In month view you can use FilledCell which has backgroundColor property or return your own custom widget. Please refer this default cell builder Widget _defaultCellBuilder( date, List<CalendarEventData<T>> events, isToday, isInMonth, hideDaysNotInMonth, ) { if (hideDaysNotInMonth) { return FilledCell<T>( date: date, shouldHighlight: isToday, backgroundColor: isInMonth ? Constants.white : Constants.offWhite, events: events, isInMonth: isInMonth, onTileTap: widget.onEventTap, dateStringBuilder: widget.dateStringBuilder, hideDaysNotInMonth: hideDaysNotInMonth, ); } return FilledCell<T>( date: date, shouldHighlight: isToday, backgroundColor: isInMonth ? Constants.white : Constants.offWhite, events: events, onTileTap: widget.onEventTap, onTileLongTap: widget.onEventLongTap, dateStringBuilder: widget.dateStringBuilder, onTileDoubleTap: widget.onEventDoubleTap, hideDaysNotInMonth: hideDaysNotInMonth, ); } — Reply to this email directly, view it on GitHub <#435 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32OFYNAPSKJLV3GR2LPL2IEFETAVCNFSM6AAAAABUKMP2HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGIYTSNJQG4> . You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

[bsutton]

also is there a reason why the second call to FilledCell in _defaultCellBuilder is missing the 'onTileDoubleTap' argument. It looks like it might be a bug?

…

On Mon, Dec 30, 2024 at 8:13 PM shubham-jitiya-simform < ***@***.***> wrote: Hi @bsutton <https://github.com/bsutton>, In month view you can use FilledCell which has backgroundColor property or return your own custom widget. Please refer this default cell builder Widget _defaultCellBuilder( date, List<CalendarEventData<T>> events, isToday, isInMonth, hideDaysNotInMonth, ) { if (hideDaysNotInMonth) { return FilledCell<T>( date: date, shouldHighlight: isToday, backgroundColor: isInMonth ? Constants.white : Constants.offWhite, events: events, isInMonth: isInMonth, onTileTap: widget.onEventTap, dateStringBuilder: widget.dateStringBuilder, hideDaysNotInMonth: hideDaysNotInMonth, ); } return FilledCell<T>( date: date, shouldHighlight: isToday, backgroundColor: isInMonth ? Constants.white : Constants.offWhite, events: events, onTileTap: widget.onEventTap, onTileLongTap: widget.onEventLongTap, dateStringBuilder: widget.dateStringBuilder, onTileDoubleTap: widget.onEventDoubleTap, hideDaysNotInMonth: hideDaysNotInMonth, ); } — Reply to this email directly, view it on GitHub <#435 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32OFYNAPSKJLV3GR2LPL2IEFETAVCNFSM6AAAAABUKMP2HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGIYTSNJQG4> . You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

[bsutton]

it's also missing onTileLongTap.

[shubham-jitiya-simform]

also is there a reason why the second call to FilledCell in _defaultCellBuilder is missing the 'onTileDoubleTap' argument. It looks like it might be a bug?

Hi, @bsutton
We appreciate you bringing the missing taps to our attention.
The necessary changes have now been successfully merged in PR #440.