-
Notifications
You must be signed in to change notification settings - Fork 44.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Poetry v2.0.0 compatibility #9197
Merged
Pwuts
merged 7 commits into
dev
from
pwuts/open-2296-remove-no-update-from-poetry-commands-in-ci
Jan 6, 2025
Merged
Fix Poetry v2.0.0 compatibility #9197
Pwuts
merged 7 commits into
dev
from
pwuts/open-2296-remove-no-update-from-poetry-commands-in-ci
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
Pwuts
changed the title
ci(backend): Remove poetry
ci(backend): Remove deprecated poetry lock Jan 6, 2025
--no-update
flag--no-update
flag
✅ Deploy Preview for auto-gpt-docs canceled.
|
Pwuts
requested review from
Swiftyos and
aarushik93
and removed request for
a team
January 6, 2025 11:53
github-actions
bot
added
Classic AutoGPT Agent
Forge
Classic Benchmark
size/xl
and removed
size/l
labels
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9197 +/- ##
======================================
Coverage ? 49.62%
======================================
Files ? 144
Lines ? 8916
Branches ? 1240
======================================
Hits ? 4425
Misses ? 4344
Partials ? 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pwuts
changed the title
ci(backend): Remove deprecated poetry lock
ci(backend): Fix Poetry v2.0.0 compatibility
Jan 6, 2025
--no-update
flag
kcze
previously approved these changes
Jan 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
- Resolves #9196 Make all changes necessary to make everything work with Poetry v2.0.0. ## Changes - Removed `--no-update` flag from `poetry lock` command in codebase - Removed extra path arguments from `poetry -C [path] run [command]` occurrences - Regenerated all lock files in hierarchical order ### Relevant (breaking) changes in v2.0.0 - `--no-update` flag no longer exists for `poetry lock` as it has become default behavior - The `-C` option now actually changes the directory, so any path arguments in `poetry run` commands can/must be removed - Poetry v2.0.0 uses the new v2.1 lock file spec, so all lock files have to be regenerated to avoid false-positive lock file updates and checks on future PRs Full release notes and change log: https://python-poetry.org/blog/announcing-poetry-2.0.0
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 6, 2025
- fix .dockerignore - fixes .venv being erroneously copied over from local - fixes build context bloat (300MB -> 2.5MB) - fix warnings about entrypoint script not being installed - workaround for Poetry bug where `packages.[i].format` is now suddenly required
kcze
previously approved these changes
Jan 6, 2025
Pwuts
changed the title
ci(backend): Fix Poetry v2.0.0 compatibility
Fix Poetry v2.0.0 compatibility
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 6, 2025
kcze
approved these changes
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 6, 2025
Pwuts
deleted the
pwuts/open-2296-remove-no-update-from-poetry-commands-in-ci
branch
January 6, 2025 22:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all changes necessary to make everything work with Poetry v2.0.0.
Changes
--no-update
flag frompoetry lock
command in codebasepoetry -C [path] run [command]
occurrencespackages.[i].format
is now suddenly requiredAdditionally:
Relevant (breaking) changes in v2.0.0
--no-update
flag no longer exists forpoetry lock
as it has become default behavior-C
option now actually changes the directory, so any path arguments inpoetry run
commands can/must be removedpoetry.tool.packages
,format
is required nowpoetry run
fails with a keyerror for poetry 2.0.0 python-poetry/poetry#9961Full release notes and change log: https://python-poetry.org/blog/announcing-poetry-2.0.0