Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address small feedbacks #412

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Address small feedbacks #412

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b497cf
Use case switch for parser option conditionals
st0012 Feb 17, 2025
bac6a49
Rename snake_case function names to camelCase versions for convention
st0012 Feb 17, 2025
047282e
Avoid using relative imports
st0012 Feb 17, 2025
e231b43
Remove incorrectly added code
st0012 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser/prism/Translator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef SORBET_PARSER_PRISM_TRANSLATOR_H
#define SORBET_PARSER_PRISM_TRANSLATOR_H

#include "../Node.h" // To clarify: these are Sorbet Parser nodes, not Prism ones.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I didn't know any better at the time.

#include "core/errors/parser.h"
#include "parser/Node.h" // To clarify: these are Sorbet Parser nodes, not Prism ones.
#include "parser/prism/Parser.h"
#include <memory>

Expand Down