Address small feedbacks #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
prism-squashed
branch
from
a75c68f to
fc831c6
Compare
This will allow the compiler to check that all parser options are handled. Addresses https://github.com/sorbet/sorbet/pull/8485/files#r1943122296
st0012
force-pushed
the
address-small-feedbacks
branch
from
df6bad1 to
e231b43
Compare
amomchilov
approved these changes
Feb 18, 2025
| @@ -1,8 +1,8 @@ | |||
| #ifndef SORBET_PARSER_PRISM_TRANSLATOR_H | |||
| #define SORBET_PARSER_PRISM_TRANSLATOR_H | |||
|
|
|||
| #include "../Node.h" // To clarify: these are Sorbet Parser nodes, not Prism ones. | |||
There was a problem hiding this comment.
Heh, I didn't know any better at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses a few smaller feedback from sorbet#8122 and sorbet#8485. I've linked to the respective comments in the commit messages, so I recommend reviewing by commits.
Test plan
See included automated tests.