Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update Prisma from 4.13.0 to 5.8.1 #589

Merged
merged 3 commits into from
Jan 22, 2024
Merged

[Enhancement] Update Prisma from 4.13.0 to 5.8.1 #589

merged 3 commits into from
Jan 22, 2024

Conversation

petradonka
Copy link
Contributor

WHY are these changes introduced?

Fixes #400

Upgrade the Prisma ORM version of @shopify/shopify-app-session-storage-prisma to the latest to incorporate the improvements in the latest versions.

WHAT is this pull request doing?

Simple dependency bump. No breaking changes are known to be relevant to @shopify/shopify-app-session-storage-prisma.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@petradonka petradonka requested a review from a team as a code owner January 20, 2024 15:00
@petradonka
Copy link
Contributor Author

I believe there will also be other version bumps needed in other repos, because of the peer dependency version requirement:

What's the best way to go about this to make sure any dependent changes across repos are in sync?

@petradonka
Copy link
Contributor Author

I have signed the CLA!

@paulomarg
Copy link
Contributor

Hey Petra, thanks for contributing! I'll be reviewing this today, but I expect it'll be an easy one if there are no breaking changes :)

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on the template and it works just fine :)

@@ -0,0 +1,5 @@
---
'@shopify/shopify-app-session-storage-prisma': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be a major bump instead - because the template also imports prisma directly, there'll be a version mismatch for existing apps that will block them from updating this package until they go over to prisma 5, and that might mean some breaking changes to their app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd make sense for me. Should I update the changeset?

I think this also relates to my question above: how do we best go about "syncing" this bump across the various repos, exactly because of that peer dep version mismatch?

Copy link
Contributor

@paulomarg paulomarg Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I totally missed that comment. And yeah, we'll need to bump the dependency on all of those repos - the major version bump would prevent them from breaking in the meantime, which is nice.

Once we merge / release this, we'll need to bump each of the template repos, but that should be pretty easy.

I'd say let's go with a major bump and once we release it I can create separate PRs for those, it should be a quick update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I changed this to a major bump, changeset should be good to go then.

@paulomarg paulomarg merged commit 23e0f85 into Shopify:main Jan 22, 2024
6 checks passed
@blanklob
Copy link

This is not published to npm right? @paulomarg

@paulomarg
Copy link
Contributor

Not yet, we're planning on publishing soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Upgrade @shopify/shopify-app-session-storage-prisma to Prisma v5
3 participants