-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Update Prisma from 4.13.0 to 5.8.1 #589
Conversation
I believe there will also be other version bumps needed in other repos, because of the peer dependency version requirement:
What's the best way to go about this to make sure any dependent changes across repos are in sync? |
I have signed the CLA! |
Hey Petra, thanks for contributing! I'll be reviewing this today, but I expect it'll be an easy one if there are no breaking changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on the template and it works just fine :)
.changeset/ninety-rivers-worry.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
'@shopify/shopify-app-session-storage-prisma': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be a major bump instead - because the template also imports prisma directly, there'll be a version mismatch for existing apps that will block them from updating this package until they go over to prisma 5, and that might mean some breaking changes to their app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd make sense for me. Should I update the changeset?
I think this also relates to my question above: how do we best go about "syncing" this bump across the various repos, exactly because of that peer dep version mismatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I totally missed that comment. And yeah, we'll need to bump the dependency on all of those repos - the major version bump would prevent them from breaking in the meantime, which is nice.
Once we merge / release this, we'll need to bump each of the template repos, but that should be pretty easy.
I'd say let's go with a major bump and once we release it I can create separate PRs for those, it should be a quick update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I changed this to a major bump, changeset should be good to go then.
This is not published to npm right? @paulomarg |
Not yet, we're planning on publishing soon! |
WHY are these changes introduced?
Fixes #400
Upgrade the Prisma ORM version of
@shopify/shopify-app-session-storage-prisma
to the latest to incorporate the improvements in the latest versions.WHAT is this pull request doing?
Simple dependency bump. No breaking changes are known to be relevant to
@shopify/shopify-app-session-storage-prisma
.Type of change
Checklist
yarn changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
files manually)