Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Upgrade @shopify/shopify-app-session-storage-prisma to Prisma v5 #400

Closed
blanklob opened this issue Aug 12, 2023 · 13 comments · Fixed by #589
Closed

[Enhancement] Upgrade @shopify/shopify-app-session-storage-prisma to Prisma v5 #400

blanklob opened this issue Aug 12, 2023 · 13 comments · Fixed by #589

Comments

@blanklob
Copy link

Overview/summary

-- Resources --

https://www.prisma.io/docs/guides/upgrade-guides/upgrading-versions/upgrading-to-prisma-5

@byrichardpowell
Copy link
Contributor

Hey @blanklob Thanks for opening this issue.

The timing of the Prisma V5 release was funny. Just as we went live with the prisma package

We'll get to, but to set expectations it's somewhere down the list.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Oct 31, 2023
@fullStackDataSolutions
Copy link

Any update on when this will be bumped up? Will it even break anything to move it up to 5?

@github-actions github-actions bot removed the Stale label Nov 3, 2023
@boxedcode
Copy link

Any update from the Shopify team on this enhancement?

@Rafi993
Copy link

Rafi993 commented Jan 7, 2024

+1

@yuvrajharod
Copy link

hey @byrichardpowell , really need this one as it brings major feature updates, I tried updating myself but it's dependent on this package which make this really important...

@Alex-Levacher
Copy link

Hey Shopify team 👋🏻 Is there any reason to not upgrade the Prisma version ? Thank you 😊

@JoseRoman
Copy link

This would be helpful

@paulomarg
Copy link
Contributor

Sorry for the delay folks, we're looking into it as per #589!

@blanklob
Copy link
Author

blanklob commented Jan 24, 2024

No upgrade guide right I just update shopify app package and prisma?

@paulomarg
Copy link
Contributor

Yup! The table schema and API stay the same - we only made it a major bump because there's a peer dependency on Prisma itself, so you'll need to update your app's dependency as well and we didn't want to force folks to update.

@boxedcode
Copy link

@paulomarg What's the new major version of the package? I'm only seeing version 2.0.3 published here

@paulomarg
Copy link
Contributor

paulomarg commented Jan 24, 2024

We're planning on releasing soon! It'll be bumped to v3 when that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants