Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 14 support #459

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Remove node 14 support #459

merged 2 commits into from
Oct 5, 2023

Conversation

paulomarg
Copy link
Contributor

@paulomarg paulomarg commented Oct 3, 2023

Node 14 has reached EOL, and some dependencies we use no longer work with it.

Therefore, we have to drop support for that version in order to upgrade our dependencies.

@paulomarg paulomarg requested a review from a team as a code owner October 3, 2023 20:27
@paulomarg paulomarg changed the title Remove node 14 support Remove node 14 and 16 support Oct 4, 2023
@paulomarg paulomarg force-pushed the remove_node_14_support branch from 36fdaec to c269f5b Compare October 4, 2023 13:53
Copy link
Contributor

@byrichardpowell byrichardpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@byrichardpowell
Copy link
Contributor

Chatted in person. Let's spike only dropping 14 & 16 for Remix and see how much extra complexity it gives us.

@paulomarg paulomarg force-pushed the remove_node_14_support branch from c269f5b to 68997c4 Compare October 5, 2023 15:41
@paulomarg paulomarg changed the title Remove node 14 and 16 support Remove node 14 support Oct 5, 2023
@paulomarg paulomarg merged commit c8eb309 into main Oct 5, 2023
11 checks passed
@paulomarg paulomarg deleted the remove_node_14_support branch October 5, 2023 16:57
@paulomarg
Copy link
Contributor Author

We decided to drop 14 across the board but keep support for 16 as a relevant number of apps still use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants