Merge pull request #459 from Shopify/remove_node_14_support

Remove node 14 support

.changeset/chilled-bobcats-brush.md

@@ -0,0 +1,24 @@
+---
+'@shopify/shopify-app-remix': major
+'@shopify/shopify-app-express': major
+'@shopify/shopify-app-session-storage': major
+'@shopify/shopify-app-session-storage-dynamodb': major
+'@shopify/shopify-app-session-storage-kv': major
+'@shopify/shopify-app-session-storage-memory': major
+'@shopify/shopify-app-session-storage-mongodb': major
+'@shopify/shopify-app-session-storage-mysql': major
+'@shopify/shopify-app-session-storage-postgresql': major
+'@shopify/shopify-app-session-storage-prisma': major
+'@shopify/shopify-app-session-storage-redis': major
+'@shopify/shopify-app-session-storage-sqlite': major
+'@shopify/shopify-app-session-storage-test-utils': patch
+---
+
+### Removed support for Node 14
+
+Node 14 has reached it's [EOL](https://endoflife.date/nodejs), and dependencies to this package no longer work on Node 14.
+Because of that, we can no longer support that version.
+
+If your app is running on Node 14, you'll need to update to a more recent version before upgrading this package.
+
+This upgrade does not require any code changes.

.github/workflows/ci.yml

@@ -6,14 +6,13 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: [14, 16, 18, 20]
+        version: [16, 18, 20]
     steps:
       - uses: actions/checkout@master
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.version }}
       - name: Install
-        # TODO remove the --ignore-engines flag when node 14 support is dropped
         run: yarn install --ignore-engines
       - name: Run tests
         run: yarn test

packages/shopify-app-express/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-remix/loom.config.ts

@@ -20,7 +20,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-dynamodb/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-kv/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-kv/src/__tests__/kv.test.ts

@@ -1,9 +1,21 @@
-import semver from 'semver';
+import {Miniflare} from 'miniflare';
+import {batteryOfTests} from '@shopify/shopify-app-session-storage-test-utils';
 
-// eslint-disable-next-line no-warning-comments
-// TODO Remove this file and rename kv.test.actual.ts to kv.test.ts when we drop support for Node 14
-if (semver.gte(process.version, '15.0.0')) {
-  require('./kv.test.actual');
-}
+import {KVSessionStorage} from '../kv';
 
-test('dummy test', () => expect(1).toEqual(1));
+describe('KVSessionStorage', () => {
+  let storage: KVSessionStorage | undefined;
+  beforeAll(async () => {
+    const mf = new Miniflare({
+      scriptPath:
+        'packages/shopify-app-session-storage-kv/src/__tests__/kv-namespace-dummy-worker.ts',
+      kvNamespaces: ['KV_TEST_NAMESPACE'],
+    });
+
+    storage = new KVSessionStorage(
+      await mf.getKVNamespace('KV_TEST_NAMESPACE'),
+    );
+  });
+
+  batteryOfTests(async () => storage!);
+});

packages/shopify-app-session-storage-memory/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-mongodb/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-mysql/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-postgresql/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-prisma/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-redis/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-sqlite/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage-test-utils/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.

packages/shopify-app-session-storage/loom.config.ts

@@ -9,7 +9,7 @@ export default createPackage((pkg) => {
       // Use browser targets (e.g. `'defaults'`) if your package targets the browser,
       // node targets (e.g. `'node 12.22'`) if your package targets node
       // or both (e.g.`'defaults, node 12.22'`) if your package targets both
-      targets: 'node 14',
+      targets: 'node 16',
       // Optional. Defaults to false. Defines if commonjs outputs should be generated.
       commonjs: true,
       // Optional. Defaults to false. Defines if esmodules outputs should be generated.