Add option to change the type of user #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: macos
feature: analytics
|
Visit the preview URL for this PR (updated for commit 72a584b): https://sharezone-test--pr1349-change-account-type-61q55fat.web.app (expires Thu, 07 Mar 2024 19:59:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Mar 3, 2024
| import 'package:cloud_functions/cloud_functions.dart'; | ||
| import 'package:user/user.dart'; | ||
|
|
||
| class ChangeTypeOfUserRepository { |
There was a problem hiding this comment.
Its not really a Repository, lets just call it ChangeTypeOfUserService instead I'd say.
There was a problem hiding this comment.
Or anything else, just not Repository since it does not follow the Repository pattern.
|
Don't forget to change the PR if you implement my suggestion on the backend ( |
Jonas-Sander
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user can change twice every two weeks their type of user in the app setting without contacting the support.
Demo
Changing type of user
Screen.Recording.2024-03-03.at.17.46.57.mov
When the user changed too often the type of user
Screen.Recording.2024-03-03.at.17.48.48.mov
Related tickets
Closes #556