Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail template for changing account type has "+" where spaces should be. #100

Closed
Jonas-Sander opened this issue Jan 31, 2022 · 4 comments
Closed
Labels
bug Something isn't working. good first issue This issue is good for new contributors. Easy to fix.

Comments

@Jonas-Sander
Copy link
Collaborator

Describe the bug

When selecting the "contact support" option on the change account type dialog the template text has "+" where spaces should be on some platforms.

Steps to Reproduce

  1. Go to Settings ("Einstellungen") > My account ("Mein Konto").
  2. Tap onto account type ("Account-Type") tile.
  3. Tap "contact support" ("Support kontaktieren") button in the dialog.

Current broken behavior

The text contains "+" where spaces should be.

Expected behavior

The text should not have these special characters instead of spaces etc.

Screenshots, videos or logs

Tested device

This does NOT happen with the web app when having gmail inside the browser as the default mail handler.

Additional context

UrlLauncherExtended seems to encode the template text as an URL which causes spaces to be changed to "+".

Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1404

@Jonas-Sander Jonas-Sander added the bug Something isn't working. label Jan 31, 2022
@Jonas-Sander
Copy link
Collaborator Author

@nilsreichardt Can you add a Screenshot and write on which devices this happens?

@nilsreichardt
Copy link
Member

image

Tested with iPhone

@nilsreichardt nilsreichardt added the good first issue This issue is good for new contributors. Easy to fix. label Feb 13, 2024
@nilsreichardt nilsreichardt moved this to Someday in Triage May 3, 2024
@ImGxrke
Copy link
Contributor

ImGxrke commented Jun 30, 2024

Issue can be closed due to #1349 allowing users to change their account type themselves.

@nilsreichardt
Copy link
Member

That's correct, thanks!

@github-project-automation github-project-automation bot moved this from Someday to Closed in Triage Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. good first issue This issue is good for new contributors. Easy to fix.
Projects
Status: Closed
Development

No branches or pull requests

3 participants