-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flavors to macOS #1078
Add flavors to macOS #1078
Conversation
Visit the preview URL for this PR (updated for commit 78c763a): https://sharezone-test--pr1078-macos-flavor-2-lgsnw1cz.web.app (expires Mon, 18 Dec 2023 14:39:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Current status: The PR should be ready, but there is a bug in the |
); | ||
MACOSX_DEPLOYMENT_TARGET = 10.15; | ||
PRODUCT_BUNDLE_IDENTIFIER = de.codingbrain.sharezone.app.dev; | ||
PRODUCT_NAME = dev_Sharezone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS, we use the product name "dev Sharezone" for the dev environment. However, the FlutterFire CLI has a bug and doesn't support spaces in the product name, see invertase/flutterfire_cli#243. Therefore, we use a workaround "dev_Sharezone" instead of "dev Sharezone" as product name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! 👍
Summary
With this PR, we support
prod
anddev
flavors for our macOS app. Make you sure, you have the FlutterFire CLI installed (version 0.3.0-dev.18 or higher), if you want to build for macOS. The FlutterFire CLI is used during the build process in the XCode build phases (configuring bundle service files and uploading Crashlytics symbols).Details
Because the process of adding Firebase flavors to our macOS isn't documented well (there is a open PR with more documentation: invertase/flutterfire_cli#224), I'm describing here, what I did to support flavors.
First, I needed to execute the following commands:
The commands configure Firebase for each build config (
Debug-dev
,Profile-dev
,Release-dev
,Debug-prod
,Profile-prod
,Release-prod
).Additionally, I needed to set
debug information format
toDWARF with dSYM File
, see https://firebase.google.com/docs/crashlytics/get-started?platform=ios#set-up-dsym-uploading.Related Tickets
Closes #352
Related to invertase/flutterfire_cli#14