Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace google_sign_in_dartio with google_sign_in #1178

Closed
nilsreichardt opened this issue Dec 8, 2023 · 1 comment · Fixed by #1198
Closed

Replace google_sign_in_dartio with google_sign_in #1178

nilsreichardt opened this issue Dec 8, 2023 · 1 comment · Fixed by #1198
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. platform: macos

Comments

@nilsreichardt
Copy link
Member

nilsreichardt commented Dec 8, 2023 •
edited
Loading

Since the v6.2.0 google_sign_in supports also macOS. Therefore, we remove google_sign_in_dartio as a dependency.
@nilsreichardt nilsreichardt added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. platform: macos dependencies Changing, updating, adding or removing one or more dependencies. labels Dec 8, 2023
@nilsreichardt
Copy link
Member Author

It's recommended to first implement #1078.

@nilsreichardt nilsreichardt changed the title Replace google_sign_in_dart with google_sign_in Replace google_sign_in_dartio with google_sign_in Dec 8, 2023
@nilsreichardt nilsreichardt changed the title Replace google_sign_in_dartio with google_sign_in Replace google_sign_in_dartio with google_sign_in Dec 8, 2023
@nilsreichardt nilsreichardt mentioned this issue Dec 15, 2023
Merged
nilsreichardt added a commit that referenced this issue Dec 25, 2023
@nilsreichardt
Remove google_sign_in_dartio (#1198)
bc3f187 
The `google_sign_in` package supports since v6.2.0 Google Sign In for
macOS (flutter/packages#5600). Therefore, the no
need for the `google_sign_in_dartio` package anymore. Additionally, this
PR adds Google Sign In for our dev environment (besides prod).

Closes #1178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. platform: macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove google_sign_in_dartio SharezoneApp/sharezone-app
1 participant
@nilsreichardt