Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better water detection on altitude lakes. #43

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

jmbau
Copy link
Collaborator

@jmbau jmbau commented Aug 11, 2023

For now, water detection works good at sea level, but it is difficult for altitude water bodies:

  • If water surface is made with a full black (0x000000) color, surface becomes invisible and player can see through it up to sea level.
  • If water surface is made with alpha channel at 50% opacity, it is always possible to see through surface. By setting transparency detection at at least 99% opacity, surface is detected as water but it is not possible to anything trough it. Result can be checked on any altitude body of Corsica scenery update.

For now, water detection works good at sea level, but it is difficult for altitude water bodies:
- If water surface is made with a full black (0x000000) color, surface becomes invisible and player can see through it up to sea level.
- If water surface is made with alpha channel at 50% opacity, it is always possible to see through surface.
By setting transparency detection at at least 99% opacity, surface is detected as water but it is not possible to anything trough it.
Result can be checked on any altitude body of Corsica scenery update.
Copy link
Member

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a bit hacky but ok...

@hsanjuan hsanjuan merged commit f0c0ed2 into master Aug 11, 2023
1 check passed
@hsanjuan hsanjuan deleted the splash_detection branch August 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants