-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Code Standards #147
Conversation
avik-pal
commented
May 25, 2024
- Explicit Imports
- Standardize formatting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 90.58% 90.60% +0.02%
==========================================
Files 23 23
Lines 1296 1299 +3
==========================================
+ Hits 1174 1177 +3
Misses 122 122 ☔ View full report in Codecov by Sentry. |
3d29055
to
c6dc7b7
Compare
.JuliaFormatter.toml
Outdated
style = "sciml" | ||
format_markdown = true | ||
annotate_untyped_fields_with_any = false | ||
format_docstrings = true No newline at end of file | ||
format_docstrings = true | ||
join_lines_based_on_source = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thazhemadam are we able to standardize this in the .github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotate_untyped_fields_with_any = false
is a better case only if ConcreteStructs are being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though join_lines_based_on_source = false
makes the formatting more standard across different authors
c6dc7b7
to
9984298
Compare