Use DifferentiationInterface #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 90.60% 90.34% -0.26%
==========================================
Files 23 21 -2
Lines 1299 1202 -97
==========================================
- Hits 1177 1086 -91
+ Misses 122 116 -6 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avik-pal
force-pushed
the
ap/di
branch
7 times, most recently
from
f111bd3
to
5ef7667
Compare
ChrisRackauckas
approved these changes
May 26, 2024
|
Any issues with DI integration @avik-pal ? |
gdalle
reviewed
May 27, 2024
| mul!(reshape(du, 1, :), vec(DiffResults.value(res))', | ||
| DiffResults.jacobian(res), 2, false) | ||
| resid = __similar(du, length(sol.resid)) | ||
| v, J = DI.value_and_jacobian(_f, resid, AutoForwardDiff(), u) |
There was a problem hiding this comment.
you may want to use preparation
| 2 .* vec(DiffResults.value(res))' * DiffResults.jacobian(res), | ||
| size(u)) | ||
| _f = Base.Fix2(prob.f, p) | ||
| v, J = DI.value_and_jacobian(_f, AutoForwardDiff(), u) |
| __f = (du, u) -> f(du, u, p) | ||
| ForwardDiff.jacobian(__f, du, u) | ||
| __f = @closure (du, u) -> f(du, u, p) | ||
| return ForwardDiff.jacobian(__f, __similar(u), u) |
| return ForwardDiff.jacobian(__f, u) | ||
| end | ||
| u isa Number && return ForwardDiff.derivative(__f, u) | ||
| return ForwardDiff.jacobian(__f, u) |
| value_and_jacobian(ad, f, y, x, p, cache; J = nothing) | ||
| function value_and_jacobian( | ||
| ad, prob::AbstractNonlinearProblem, f::F, y, x, cache; J = nothing) where {F} | ||
| x isa Number && return DI.value_and_derivative(f, ad, x, cache) |
There was a problem hiding this comment.
was the cache obtained with DI.prepare_derivative(f, ad, x)?
Comment on lines
+65
to
+66
| H = DI.second_derivative(f, ad, x) | ||
| v, J = DI.value_and_derivative(f, ad, x) |
| return fx, dfx, d2fx | ||
| df = @closure x -> begin | ||
| res = __similar(y, promote_type(eltype(y), eltype(x))) | ||
| return DI.jacobian(f, res, ad, x) |
| res = __similar(y, promote_type(eltype(y), eltype(x))) | ||
| return DI.jacobian(f, res, ad, x) | ||
| end | ||
| J, H = DI.value_and_jacobian(df, ad, x) |
| dfx = J_fn(x) | ||
| d2fx = ForwardDiff.jacobian(J_fn, x) | ||
| return fx, dfx, d2fx | ||
| df = @closure x -> begin |
There was a problem hiding this comment.
you can use DI with functions f!(y, x) without the closure
Comment on lines
+220
to
232
| @inline function __get_concrete_autodiff(prob, ad::AutoForwardDiff{nothing}; kwargs...) | ||
| return AutoForwardDiff(; chunksize = ForwardDiff.pickchunksize(length(prob.u0)), ad.tag) | ||
| end | ||
| @inline function __get_concrete_autodiff( | ||
| prob, ad::AutoPolyesterForwardDiff{nothing}; kwargs...) | ||
| return AutoPolyesterForwardDiff(; | ||
| chunksize = ForwardDiff.pickchunksize(length(prob.u0)), ad.tag) | ||
| end | ||
| @inline function __get_concrete_autodiff(prob, ::Nothing; kwargs...) | ||
| return ifelse( | ||
| ForwardDiff.can_dual(eltype(prob.u0)), AutoForwardDiff(), AutoFiniteDiff()) | ||
| return ifelse(ForwardDiff.can_dual(eltype(prob.u0)), | ||
| AutoForwardDiff(; chunksize = ForwardDiff.pickchunksize(length(prob.u0))), | ||
| AutoFiniteDiff()) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleHalleynow supports in place problemsTODOs