Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass VariableUnit of diff var while converting it to a Term #2583

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: pass VariableUnit of diff var while converting it to a Term #2583

wants to merge 4 commits into from

Commits on May 1, 2024

  1. fix: pass VariableUnit of diff var while converting it to a Term 

    Units are defined only in MTK, so pass this piece of info to `Symbolics.diff2term` to add this to the returning term-var.
    @ven-k
    ven-k committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7a6c1ee View commit details
    Browse the repository at this point in the history

  2. chore: bump Symbolics to v5.28

    @ven-k
    ven-k committed May 1, 2024
    Configuration menu
    Copy the full SHA
    08d0a63 View commit details
    Browse the repository at this point in the history

  3. fix: don't screen unit for a Unitful unit 

        `__get_literal_unit` already screens units of DynamicQuantity.AbstractQuantity. So this check is redundant.
    Also, removing this check fixes the issue with `get_unit` for units of Unitful type.
    @ven-k
    ven-k committed May 1, 2024
    Configuration menu
    Copy the full SHA
    08833bc View commit details
    Browse the repository at this point in the history

  4. fix: remove the accidentally added diff file

    @ven-k
    ven-k committed May 1, 2024
    Configuration menu
    Copy the full SHA
    27e2699 View commit details
    Browse the repository at this point in the history