fix: pass VariableUnit
of diff var while converting it to a Term
#2583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
diff2term
JuliaSymbolics/Symbolics.jl#1104.Units are defined only in MTK, so pass this piece of info to
Symbolics.diff2term
to add this to the returning term-var.With this PR:
k_t
's unit will be1.0 s⁻¹
And prints a clear warning message whenever the term arg has a non SI unit.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.