Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update set_infrastructure _type for RHCloud #17196

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update set_infrastructure _type for RHCloud #17196

merged 2 commits into from
Jan 7, 2025

Conversation

ColeHiggins2
Copy link
Member

The set_infrastructure_set helper function was not actually setting the infrastructure type. After Speaking with Dev and Insights, I have rewritten the function to set these facts properly. This should fix failing tests in RHCloud

@ColeHiggins2 ColeHiggins2 added Framework Changes A modification of the robottelo framework CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 17, 2024
@ColeHiggins2 ColeHiggins2 self-assigned this Dec 17, 2024
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner December 17, 2024 15:42
@ColeHiggins2
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9656
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e --external-logging
Test Result : ========= 7 passed, 23 deselected, 1032 warnings in 5638.71s (1:33:58) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 17, 2024
JacobCallahan
JacobCallahan approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on contents. Merge pending the pre-commit checks

vsedmik
vsedmik approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK to unblock the failures.

robottelo/hosts.py Show resolved Hide resolved
@ColeHiggins2 ColeHiggins2 force-pushed the update-rhcloud-infra-type branch from 07aa120 to d8340b8 Compare January 6, 2025 19:04
@ColeHiggins2
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 6, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9764
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e --external-logging
Test Result : ========== 23 deselected, 55 warnings, 7 errors in 703.86s (0:11:43) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 6, 2025
@chris1984
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9765
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e --external-logging
Test Result : ========= 7 passed, 23 deselected, 997 warnings in 5547.06s (1:32:27) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 6, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 227ac44 into SatelliteQE:master Jan 7, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@ColeHiggins2 @web-flow
Update set_infrastructure _type for RHCloud (#17196)
1490c64 
* Update set infra type rhcloud

* update docstring

(cherry picked from commit 227ac44)
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@ColeHiggins2 @web-flow
Update set_infrastructure _type for RHCloud (#17196)
bd292d0 
* Update set infra type rhcloud

* update docstring

(cherry picked from commit 227ac44)
This was referenced Jan 7, 2025
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@ColeHiggins2 @web-flow
Update set_infrastructure _type for RHCloud (#17196)
0cab4e1 
* Update set infra type rhcloud

* update docstring

(cherry picked from commit 227ac44)
@Satellite-QE Satellite-QE mentioned this pull request Jan 7, 2025
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Jan 8, 2025
@Satellite-QE @ColeHiggins2
[6.16.z] Update set_infrastructure _type for RHCloud (#17267)
50781df 
Update set_infrastructure _type for RHCloud (#17196)

* Update set infra type rhcloud

* update docstring

(cherry picked from commit 227ac44)

Co-authored-by: Cole Higgins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@chris1984 chris1984 chris1984 approved these changes

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

@sambible sambible Awaiting requested review from sambible

@damoore044 damoore044 Awaiting requested review from damoore044

@jyejare jyejare Awaiting requested review from jyejare

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Framework Changes A modification of the robottelo framework PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ColeHiggins2 @Satellite-QE @chris1984 @JacobCallahan @Gauravtalreja1 @vsedmik