Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] Update set_infrastructure _type for RHCloud #17267

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[6.16.z] Update set_infrastructure _type for RHCloud #17267

merged 1 commit into from
Jan 8, 2025
+16 −8

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17196

The set_infrastructure_set helper function was not actually setting the infrastructure type. After Speaking with Dev and Insights, I have rewritten the function to set these facts properly. This should fix failing tests in RHCloud

@ColeHiggins2 @web-flow
Update set_infrastructure _type for RHCloud (#17196)
0cab4e1 
* Update set infra type rhcloud

* update docstring

(cherry picked from commit 227ac44)
@Satellite-QE Satellite-QE requested a review from a team as a code owner January 7, 2025 11:40
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 7, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 7, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9769
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e --external-logging
Test Result : ========== 20 deselected, 51 warnings, 6 errors in 583.00s (0:09:42) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 7, 2025
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9774
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_rhcloud_inventory.py -k test_rhcloud_inventory_api_e2e --external-logging
Test Result : ==== 2 failed, 4 passed, 20 deselected, 895 warnings in 4810.12s (1:20:10) =====

@Gauravtalreja1 Gauravtalreja1 merged commit 50781df into 6.16.z Jan 8, 2025
15 of 18 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.16.z-227ac44a2cc7e8c6d7cf41fdf96bc1754debe81e branch January 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @ColeHiggins2