Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded interface modifiers #480

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Removed unneeded interface modifiers #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bbf195
Removed unneeded interface modifiers
danielmackay Feb 13, 2025
5a181f9
Merge branch 'main' into fix-interface-warnings
danielmackay Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Application/Common/Interfaces/ICurrentUserService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

public interface ICurrentUserService
{
public string? UserId { get; }
string? UserId { get; }
}
2 changes: 1 addition & 1 deletion src/Domain/Common/Interfaces/IAggregateRoot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

public interface IAggregateRoot
{
public void AddDomainEvent(IDomainEvent domainEvent);
void AddDomainEvent(IDomainEvent domainEvent);

IReadOnlyList<IDomainEvent> PopDomainEvents();
}
12 changes: 6 additions & 6 deletions src/Domain/Common/Interfaces/IAuditable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

public interface IAuditable
{
public DateTimeOffset CreatedAt { get; }
public string? CreatedBy { get; } // TODO: String as userId? (https://github.com/SSWConsulting/SSW.CleanArchitecture/issues/76)
public DateTimeOffset? UpdatedAt { get; }
public string? UpdatedBy { get; } // TODO: String as userId? (https://github.com/SSWConsulting/SSW.CleanArchitecture/issues/76)
DateTimeOffset CreatedAt { get; }
string? CreatedBy { get; } // TODO: String as userId? (https://github.com/SSWConsulting/SSW.CleanArchitecture/issues/76)
DateTimeOffset? UpdatedAt { get; }
string? UpdatedBy { get; } // TODO: String as userId? (https://github.com/SSWConsulting/SSW.CleanArchitecture/issues/76)

public void SetCreated(DateTimeOffset createdAt, string? createdBy);
void SetCreated(DateTimeOffset createdAt, string? createdBy);

public void SetUpdated(DateTimeOffset updatedAt, string? updatedBy);
void SetUpdated(DateTimeOffset updatedAt, string? updatedBy);
}
Loading