Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unneeded interface modifiers #480

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Removed unneeded interface modifiers #480

merged 2 commits into from
Feb 13, 2025

Conversation

danielmackay
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ I noticed warnings from unneeded modifiers

  1. What was changed?

✏️ Remove public modifiers from public interfaces

  1. Did you do pair or mob programming?

✏️ No

lukecookssw
lukecookssw approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@lukecookssw lukecookssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukecookssw lukecookssw merged commit d35442b into main Feb 13, 2025
2 checks passed
@lukecookssw lukecookssw deleted the fix-interface-warnings branch February 13, 2025 06:31
@MattParkerDev
Copy link
Member

I actually prefer public on interfaces, but just a preference. (I know it is by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukecookssw lukecookssw lukecookssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmackay @MattParkerDev @lukecookssw