Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency parsing errors caused by collision_check option #3760

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jstvz
Copy link
Contributor

@jstvz jstvz commented Mar 4, 2024

A new option, collision_check, was added to the deploy task. The new option wasn't added to core/dependencies.py, so attempting to deserialize resulted in a DependencyParseError in MetaDeploy.

@jstvz jstvz requested a review from a team as a code owner March 4, 2024 23:18
@jstvz jstvz requested a review from sreddy-sf March 4, 2024 23:23
@jstvz jstvz changed the title Add collision_check option Fix dependency parsing errors caused by collision_check option Mar 4, 2024
@jstvz jstvz force-pushed the fix-collision-check-parse-err branch from aa3dc8f to f6496fe Compare March 5, 2024 19:01
@jstvz jstvz enabled auto-merge (squash) March 5, 2024 19:14
@jstvz jstvz merged commit eeb0f73 into main Mar 5, 2024
21 checks passed
@jstvz jstvz deleted the fix-collision-check-parse-err branch March 5, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants