Skip to content

Commit

Permalink
Fix dependency parsing errors caused by collision_check option (#3760)
Browse files Browse the repository at this point in the history
A new option, `collision_check`, was added to the `deploy` task. The new
option wasn't added to `core/dependencies.py`, so attempting to
deserialize resulted in a DependencyParseError in MetaDeploy.
  • Loading branch information
jstvz authored Mar 5, 2024
1 parent 260cc76 commit eeb0f73
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions cumulusci/core/dependencies/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ class UnmanagedDependency(StaticDependency, abc.ABC):
subfolder: Optional[str] = None
namespace_inject: Optional[str] = None
namespace_strip: Optional[str] = None
collision_check: Optional[bool] = None

def _get_unmanaged(self, org: OrgConfig):
if self.unmanaged is None:
Expand Down
10 changes: 10 additions & 0 deletions cumulusci/core/dependencies/tests/test_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -903,3 +903,13 @@ def test_parse_unmanaged_dependency(self):
}
)
assert isinstance(u, UnmanagedZipURLDependency)

u = parse_dependency(
{
"github": "https://github.com/Test/TestRepo",
"ref": "aaaaaaaa",
"collision_check": False,
"namespace_inject": "ns",
}
)
assert isinstance(u, UnmanagedGitHubRefDependency)

0 comments on commit eeb0f73

Please sign in to comment.