Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stable Ids in AddFragment and ControllerExtension forms #2816

Merged
merged 7 commits into from
Jan 29, 2025
+26 −6
Merged

feat: Add stable Ids in AddFragment and ControllerExtension forms #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c9f4c70
feat: add stable ids
GDamyanov Jan 22, 2025
353a41c
refactor: format xml
GDamyanov Jan 23, 2025
0fcbf7a
chore: add changeset
GDamyanov Jan 23, 2025
8bb1fbe
chore: format file
GDamyanov Jan 27, 2025
a15dd8b
Merge branch 'main' into feat/2813/forms-stable-ids
GDamyanov Jan 27, 2025
0407e32
Merge branch 'main' into feat/2813/forms-stable-ids
GDamyanov Jan 29, 2025
6166e55
Merge branch 'main' into feat/2813/forms-stable-ids
GDamyanov Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/rude-dragons-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@sap-ux-private/preview-middleware-client': patch
'@sap-ux/preview-middleware': patch
---

Add stable ids in AddFragment and ControllerExtension forms
25 changes: 19 additions & 6 deletions packages/preview-middleware-client/src/adp/ui/AddFragment.fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<Dialog id="addNewFragmentDialog"
xmlns="sap.m"
xmlns:core="sap.ui.core"
xmlns:l="sap.ui.layout"
xmlns:f="sap.ui.layout.form"
title="{/title}"
contentWidth="500px"
initialFocus="aggregationName"
class="sapUiRTABorder">
<content>
<f:SimpleForm id="addNewFragmentDialog_Form"
Expand All @@ -13,9 +15,14 @@
singleContainerFullSize="false">
<f:content>
<Label visible="{/completeView}" text="{i18n>ADP_ADD_FRAGMENT_DIALOG_CONTROL_TYPE_LABEL}" />
<Text visible="{/completeView}" text="{/selectedControlName}" />
<Input
id="controlType"
visible="{/completeView}"
value="{/selectedControlName}"
editable="false" />
<Label visible="{/completeView}" text="{i18n>ADP_ADD_FRAGMENT_DIALOG_AGGREGATION_LABEL}" />
<Select
id="aggregationName"
visible="{/completeView}"
change="onAggregationChanged"
selectedKey="{/selectedAggregation/key}"
Expand All @@ -26,8 +33,8 @@
<core:Item key="{key}" text="{value}" />
</Select>
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_INDEX_LABEL}" />
<HBox alignItems="Center">
<Select
id="aggregationIndex"
enabled="{/indexHandlingFlag}"
selectedKey="{path: '/selectedIndex', type: 'sap.ui.model.type.Integer'}"
items="{
Expand All @@ -37,14 +44,20 @@
<core:Item key="{key}" text="{value}" />
</Select>
<core:Icon
id="aggregationIndexInfoIcon"
useIconTooltip="false"
visible="{/specialIndexHandlingIcon}"
src="sap-icon://message-information"
class= "sapUiTinyMarginBegin"
tooltip="{/iconTooltip}" />
</HBox>
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_FRAGMENT_NAME_LABEL}" />
width="1rem"
height="2rem"
tooltip="{/iconTooltip}">
<core:layoutData>
<l:GridData span="S6" />
</core:layoutData>
</core:Icon>
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_FRAGMENT_NAME_LABEL}" required="true" />
<Input
id="fragmentName"
description=".fragment.xml"
value="{/newFragmentName}"
liveChange="onFragmentNameInputChange">
Expand Down
1 change: 1 addition & 0 deletions packages/preview-middleware-client/src/adp/ui/ControllerExtension.fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<f:content>
<Label text="Controller Name" />
<Input
id="controllerName"
description=".js"
value="{/newControllerName}"
liveChange="onControllerNameInputChange">
Expand Down
Loading