Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stable Ids in AddFragment and ControllerExtension forms #2816

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

GDamyanov
Copy link
Contributor

feat for #2813

  • Add stable Ids in AddFragment and ControllerExtension forms

@GDamyanov GDamyanov requested a review from a team as a code owner January 22, 2025 15:58
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 0407e32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GDamyanov GDamyanov self-assigned this Jan 22, 2025
@testojs testojs self-requested a review January 23, 2025 07:37
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • simple and easy to understand change
  • manually tested - works as expected

@testojs
Copy link
Contributor

testojs commented Jan 27, 2025

We probably should also make similar changes to the TableColumn dialog https://github.com/SAP/open-ux-tools/blob/main/packages/preview-middleware-client/src/adp/ui/AddTableColumnFragments.fragment.xml

Yes, it makes sense to add the IDs. Also, with the current implementation of AddTableColumnFragments.fragment.xml, there is no relation between the first label and the respective select control (for attribute, even not explicitly set, will point to HBox now, which is wrong). This change also improves form semantics.

@testojs testojs requested a review from voicis January 28, 2025 07:39
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes looks good
  • changeset present
  • did not test locally

@GDamyanov GDamyanov merged commit 1f98f07 into main Jan 29, 2025
16 checks passed
@GDamyanov GDamyanov deleted the feat/2813/forms-stable-ids branch January 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants