-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stable Ids in AddFragment and ControllerExtension forms #2816
Conversation
🦋 Changeset detectedLatest commit: 0407e32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should also make similar changes to the TableColumn dialog https://github.com/SAP/open-ux-tools/blob/main/packages/preview-middleware-client/src/adp/ui/AddTableColumnFragments.fragment.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- simple and easy to understand change
- manually tested - works as expected
Yes, it makes sense to add the IDs. Also, with the current implementation of AddTableColumnFragments.fragment.xml, there is no relation between the first label and the respective select control ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changes looks good
- changeset present
- did not test locally
|
feat for #2813