Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Add release notes for 1.53.1 #644

Merged
merged 4 commits into from
Jan 20, 2022
Merged

[js] Add release notes for 1.53.1 #644

merged 4 commits into from
Jan 20, 2022

Conversation

jjtang1985
Copy link
Contributor

@jjtang1985 jjtang1985 commented Jan 19, 2022

What Has Changed?

This PR is re-created, as the old PR failed due to magic vale issue.
The vale issue was also reported by others here

Manual Checks?

  • Text adheres to the style guide (vale docs/)
    • Every sentence is on its own line
    • Headings use title capitalization (applies also to the sidebar and title of a document)
    • You followed naming center guidelines when referring to SAP products (e.g. SAP S/4HANA)
  • You checked your spelling and grammar (consider using Grammarly, see CONTRIBUTING.md)
  • You formatted all changed files with prettier (npm run prettier)
  • You tested if the documentation still builds (npm run build)
  • You verified all new and changed links still work (changing the id or name of a file can break links)
  • You have updated the feature matrix if you add documentation on a new feature or otherwise required.

@jjtang1985 jjtang1985 marked this pull request as ready for review January 19, 2022 17:54
@jjtang1985 jjtang1985 changed the title tests [js] Add release notes for 1.53.1 Jan 19, 2022
@jjtang1985
Copy link
Contributor Author

@MattKuhr , we faced the same vale issue again, and only recreation can fix the it.
Please feel free to vote for this issue, if you like.

These libraries are not Open Source, but free and distributed under the SAP Developer license through [npmjs.com](https://www.npmjs.com/search?q=%40sap%2Fcloud-sdk-vdm-*).
You can always generate a typed client library yourself by using our [OData](features/odata/generate-odata-client.mdx) and [Open API](features/openapi/generate-openapi-client.mdx) code generators.
To easily search for services and get typed client library for them, use our [API Business Hub integration](https://blogs.sap.com/2021/09/17/the-sap-cloud-sdk-integrates-with-the-sap-api-business-hub/).

:::

<!-- Copy and fill
## 1.xx.x [Core Modules] - January 1, 2021
## 1.xx.x [Core Modules] - January 1, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.xx.x [Core Modules] - January 1, 2022
## 1.xx.x [Core Modules] - Jan 1, 2022

Copy link
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have the discussion you suggested, but in the meantime I think this can already be merged and then improved after the discussion.

@artemkovalyov
Copy link
Member

This is a PR with an alternative strategy to provide release notes for a product as a whole: #642.

Let's have it as a part of the discussion initiated by @jjtang1985

@artemkovalyov
Copy link
Member

In the meanwhile, we can merge this.

@jjtang1985 jjtang1985 merged commit 1200983 into main Jan 20, 2022
@jjtang1985 jjtang1985 deleted the js-1.53.1-recreate branch January 20, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants