-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest release notes with CLI and Sample repo info #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care.
I feel merging the release notes might lead to confusing to the users and to us.
If the vale issue cannot be solved, I would even vote for deleting them from the release notes and keep them in some other pages if we need.
### Improvements | ||
|
||
- We updated the version of `@sap/edm-converters` to ensure Node 14 compatibility for the OData code generator. | ||
- We published a new [repository with samples and starter projects](https://github.com/SAP-samples/cloud-sdk-js) for the SAP Cloud SDK for JavaScript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel a bit confusing, as the the sample repo is not related to the new patch release.
|
||
[GitHub](https://github.com/SAP-samples/cloud-sdk-js) | ||
- We deprecated on [npm](https://www.npmjs.com/package/@sap-cloud-sdk/cli) and archived on GitHub the [SAP Cloud SDK CLI](https://github.com/SAP-archive/cloud-sdk-cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, the cli repository and the npm package has nothing to do with the patch release.
Please check #644, @artemkovalyov . |
Here's my thinking @jjtang1985, SDK is a product as a whole. Samples repo or CLI don't have any value separately. That's why I look at the release of the core module as on a train to communicate other updates related to the development with the SDK. Semantically, you are right but for customers having samples repo, CLI that is no longer developed is even more confusing. What would you prefer as an approach? Would you be confused really or is it just your assumption the customers will be confused? |
What Has Changed?
Convert release notes into slightly more logical structure
Manual Checks?
vale docs/
)CONTRIBUTING.md
)npm run prettier
)npm run build
)id
or name of a file can break links)