In-Memory Cache for CF Resources #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfHammer
reviewed
Aug 26, 2024
RalfHammer
reviewed
Aug 26, 2024
RalfHammer
reviewed
Aug 26, 2024
TheBigElmo
reviewed
Aug 28, 2024
| @@ -210,5 +254,257 @@ func NewSpaceHealthChecker(spaceGuid string, url string, username string, passwo | |||
| } | |||
| } | |||
|
|
|||
| if config.IsResourceCacheEnabled && client.resourceCache == nil { | |||
There was a problem hiding this comment.
@TheBigElmo
It assigns the resourceCache created by the organization unit client and space client and will use the spaceCache populated by the organization unit client in the cf/health.go.
Currently the health.go uses the spaceClient to call the CF API. Is this OK to use the cache populated by the organization client?
RalfHammer
changed the title
RalfHammer
previously approved these changes
Oct 7, 2024
RalfHammer
requested review from
RalfHammer
and removed request for
RalfHammer
RalfHammer
approved these changes
Oct 9, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to introduce a mechanism for batching and caching CF resources. By storing the CF resources in memory, we aim to reduce the number of requests to the CF API and avoid reaching the rate limit.
Approach
The cache feature is optional and can be enabled via the environment variable
RESOURCE_CACHE_ENABLED, which can have values oftrueorfalse.Another environment variable,
CACHE_TIMEOUT, is introduced to control the refresh of the cached resources, based on alastCacheTimeattribute of the Cache instance.At the start of the operator, an instance of a Config object is created. This config object has two attributes with values of the environment variables described above.
The first time the' spaceClient' is created, an instance of the Cache object is created and populated.
The Cache instance will be refreshed every time the cache time-out is reached.