Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #66

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

Improve performance #66

wants to merge 77 commits into from

Conversation

RalfHammer
Copy link
Contributor

@RalfHammer RalfHammer commented Oct 9, 2024 •
edited
Loading

Precondition:
This PR is based on PR-59 (#59) which should be merged first.

Refactoring:

  • Large Reconcile methods in all three controllers are split into three methods each
    (Reconcile, handleCreateOrUpdate and handleDelete)
  • Space Controller: Expensive call to find dependent service instances is moved to deletion case where it is used
    This speeds up the normal creation/update cases
  • Service Instance Controller: Expensive call to find dependent service bindings is moved to deletion case where it is used
    This speeds up the normal creation/update cases
  • Reduce number of used goroutine (remove WaitGroups from populate methods)

santiago-ventura and others added 30 commits August 12, 2024 08:55
@santiago-ventura
Add cache objects to facade.client and cf.client
4f31f81
@santiago-ventura
Add initial logic for caching resources
fdbce79
@santiago-ventura
fix some errors in code
5d28fbe
@santiago-ventura
Add logic in cf client for populating the cf cache
860820d
@santiago-ventura
GetInstance function retrieving instance from Canch
30a47ef
@santiago-ventura
"Add go routine for cache execution. Include use of env variable for …
402e470 
…the interval"
@santiago-ventura
Check for nil and ensure resourcesCache is initialized
21011cb
@shilparamasamyreddy
changes to client.go to refresh go routine
9df5828
@shilparamasamyreddy
added channel for cache refresh
e625b82
@santiago-ventura
remove no needed comment
9a5bef6
@santiago-ventura
correct typo
824a3bf
@shilparamasamyreddy
populate cache on demand based on expiry
1d3c1a6
@santiago-ventura
Refactoring Cache objects and adding more public functions.
8df71cb
@shilparamasamyreddy
Added config package to read env variables
f866ead
@shilparamasamyreddy
Adjusted the existing tests
4ee8437
@shilparamasamyreddy
added licence header in config
9d1041c
@shilparamasamyreddy
added logic to remove the deleted instance from cache
acfd78c
@shilparamasamyreddy
init instance to return owner for adopt instance scenario
edc8ddb
@shilparamasamyreddy
Code for update instance to cache
16e2d61
@shilparamasamyreddy
Added logging for testing
061f668
@RalfHammer
Merge branch 'main' into cf-cache-resources
85e0578
@shilparamasamyreddy
tests for resource cache
80b6a84
@shilparamasamyreddy
refactored the code
e750753
@shilparamasamyreddy
cf/client.go changes for resource cache
b50e1a6
@shilparamasamyreddy
Client tests are added for populate resource cache
e327ccd
@shilparamasamyreddy
small refactoring the code
4e28306
@shilparamasamyreddy
refactoring to populate resource cache function and few small changes
c5e2fd4
@RalfHammer
update populateResourceCache
070ad27
@RalfHammer
improve testing of expectations
8fdff6d
@RalfHammer
minor improvements
d8f0bdb
RalfHammer and others added 30 commits September 19, 2024 10:56
@RalfHammer
simplify/document populate functions
11a962b
@RalfHammer
remove not needed length check
863e518
@RalfHammer
Add TODO for keys in shared resource cache
443f26c
@santiago-ventura
health.go uses the cache to retrieve the space
109a262
@shilparamasamyreddy
small fix to mutex
5fbc0ad
@shilparamasamyreddy
modified the global cfResourceCache logic
a092be5
@RalfHammer
remove temporary log messages
cb8068a
@RalfHammer
enable resource cache in launch.json
781fb58
@RalfHammer
remove unneccessary type
f1d443c
@RalfHammer
fix typo
233448e
@RalfHammer
fix linting issue
a770254
@RalfHammer
get details for credentials on demand
6ce7e98
@RalfHammer
add logging
445aea1
@RalfHammer
fix error message
1eea3f2
@RalfHammer
Improve documentation about caching
bd782cf
@RalfHammer
re-activate tests during docker build
327f9bb
@RalfHammer
fix linter issues
c5ec0b1
@RalfHammer
Move expensive calls to deletion case that requires them
3f048b9
@RalfHammer
Refactor space_controller
6e7be10
@RalfHammer
Refactor instance_controller
a4ef2b6
@RalfHammer
prepare test with MaxConcurrentReconciles
5151b7f
@RalfHammer
add support for performance trace
579d8f9
@RalfHammer
reduce number of used goroutines
69200a6
@RalfHammer
Harmonize logging message
095dc79
@RalfHammer
Adapt command line args for local testing
ebb8b23
@RalfHammer
add make target analyze-performance
197bb25
@RalfHammer
Adapt name of performance trace
bef08e7
@RalfHammer
Add make target for performance analysis
ba73312
@RalfHammer
fix typo
04eb423
@RalfHammer
refactor reconcile methods
b221a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RalfHammer @santiago-ventura @shilparamasamyreddy