Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For issue #33354 (email regex validation) #33398

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Tanu1201
Copy link

Proposed changes (including videos or screenshots)

In the apps/meteor/lib/emailValidator file, there were issues with how email validation was being handled. Previously, the validation function only checked the part of the email before the "@" symbol. As a result, it incorrectly accepted invalid email addresses like tanu16782@gmail, which is missing the domain suffix.

In this PR, I have updated the code to improve the validation. It now validates the entire email address, including the part after the "." to ensure proper formatting.

Additionally, I addressed issues with the rfcEmailRegex. Previously, it failed to handle certain edge cases, such as accepting empty strings . These cases have now been fixed as part of the update.

Issue(s)

#33354

Steps to test or reproduce

Please refer to #33354 .

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 29, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 29, 2024

⚠️ No Changeset found

Latest commit: 1a14619

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@reetp
Copy link

reetp commented Sep 30, 2024

See

#33012

#33354 (comment)

Notbale:

Dotless or no TLD emails are valid emails according to the most recent RFC regarding emails (RFC 5322), this is not a bug.

This should be closed thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants