Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Email Validation on various pages #33354

Open
3 of 5 tasks
smritidoneria opened this issue Sep 14, 2024 · 3 comments
Open
3 of 5 tasks

Incorrect Email Validation on various pages #33354

smritidoneria opened this issue Sep 14, 2024 · 3 comments

Comments

@smritidoneria
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

MacOs

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

4.1.0

Rocket.Chat Server Version

6.12.1

Describe the bug

Email Validation occur at various places.

  1. while registering , the email has incorrect validation.
  2. While exporting messages

Exporting Messages-

Screen.Recording.2024-09-14.at.5.10.36.PM.mov

While registering-

Screen.Recording.2024-09-14.at.5.19.51.PM.mov

How to Reproduce

While registering-
Register yourself without the domain. The interface will lead to another page without showing any error.

Export message-
Click on export messages
Input the wrong email
click send

Describe your Expected behavior

There should be proper email validation, not allowing user to login and export messages without the proper domain.

Anything else

This problem occurs everytime.

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@smritidoneria
Copy link
Author

I'm willing to work on this, if this bug is accepted @jeanfbrito 🚀

@jeanfbrito jeanfbrito transferred this issue from RocketChat/Rocket.Chat.Electron Sep 25, 2024
@Tanu1201
Copy link

Tanu1201 commented Sep 29, 2024

@jeanfbrito I was exploring the Rocket.chat and I noticed that this issue is an valid issue, so raised the PR for this please check this
#33398

@reetp
Copy link

reetp commented Sep 30, 2024

jeanfbrito I was exploring the Rocket.chat and I noticed that this issue is an valid issue, so raised the PR for this please check this

You don't need to @ anyone - those who need to know will see.

You should check that a fix is required before starting work.

I think this is likely related to this and should be closed as not a bug:

#32974 (comment)

As per the comment here

#32974 (comment)

Dotless or no TLD emails are valid emails according to the most recent RFC regarding emails (RFC 5322), this is not a bug.

And here:

#33012 (comment)

Top-level domains (.com, .org, etc) are not mandatory for an email to be considered valid, there is no need to change this regex as this was a purposeful decision on email validation done by our engineering team.

Although it seems a bit incongruous, user@domain is valid according to RFC 5322 and therefore this is not a bug and should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants