feat: apps to service #27024
Draft
feat: apps to service #27024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thassiov
force-pushed
the
improve/apps-to-service
branch
from
cb16b47 to
d63f8ab
Compare
|
This pull request introduces 6 alerts when merging d63f8ab into ff732f9 - view on LGTM.com new alerts:
|
…sage-to-service [IMPROVE] Change orchestrator usage to service
…vice [IMPROVE] Adapt apps management to use service
|
This pull request introduces 18 alerts when merging 5077c25 into 1be4ad2 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Make the apps-engine work as a service.
Issue(s)
Steps to test or reproduce
Further comments
AECO-55
Depends on RocketChat/Rocket.Chat.Apps-engine#587