-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Apps-Engine services #28964
base: develop
Are you sure you want to change the base?
feat: Apps-Engine services #28964
Conversation
a478f56
to
68f4d71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #28964 +/- ##
===========================================
- Coverage 48.51% 48.43% -0.08%
===========================================
Files 697 697
Lines 13913 13913
Branches 2447 2447
===========================================
- Hits 6750 6739 -11
- Misses 6787 6792 +5
- Partials 376 382 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What's the criteria for splitting something into a separate service or not? |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Proposed changes (including videos or screenshots)
We're extracting the service creation from PR #27024 in worder to facilitate reviews and discussions.
Here we're just introducing the new services; the adoption of those services is mostly intended to change in future PRs
Issue(s)
Steps to test or reproduce
Further comments
AECO-119