-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate non-standard URDF capsule
tag to drake:capsule
.
#16460
Comments
Counter-proposal: add |
Here is the TODO in the current code: drake/multibody/parsing/detail_urdf_geometry.cc Lines 291 to 304 in 504c6f1
It mentions ros/urdfdom_headers#24. |
I read the TODO; that's how I got here. The consequences of your counter-proposal are: (1) delete the TODO, (2) document some set of non-prefixed community extensions to URDF that Drake honors, (3) maybe delete that documentation if the standard version ever merges. |
Yes, that sounds correct to me. I think our users are best served by keeping our current (quite reasonable) extension intact. While the thoughts captured in the TODO make sense from a conformance perspective, I don't think they actually help users in any way. If we had started with |
Got it. I think I'll close the issue, and incorporate items 1 and 2 from above into #16444. |
(Re-)discovrered while writing parsing docs. We support some non-standard legacy
capsule
tag in URDF, but the standard is unaware of it. Proposal: supportdrake:capsule
, and maybe deprecate the made-upcapsule
tag. If URDF ever introducescapsule
, at least we (hopefully by then) won't have old tags with potentially clashing syntax and semantics lying about.FYI @EricCousineau-TRI @DamrongGuoy @joemasterjohn thoughts?
The text was updated successfully, but these errors were encountered: