Populate payment type and serialise as string #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add payment type enum to PaypalPaymentDetails, and serialise this property on both PaypalPaymentDetails and CreditCardPaymentDetails as a string, in line with api docs.
Currently the
_type
enum is serialised as an int, leading paymentDetails looking like this when serialised (note the value of 0 for_type
):Additionally, the
_type
property doesn't appear to exist on thePaypalPaymentDetails
object. This PR modifies both payment detail objects to always supply the type, and serialise the type as a string, i.e: