Add payment type enum to PaypalPaymentDetails, and serialise this pro…

…perty on both PaypalPaymentDetails and CreditCardPaymentDetails as a string, in line with api docs.
Riskified · Nov 26, 2019 · 4d1160a · 4d1160a
1 parent 27650ae
commit 4d1160a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs b/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs
@@ -1,4 +1,5 @@
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Riskified.SDK.Exceptions;
 using Riskified.SDK.Model.OrderCheckoutElements;
 using Riskified.SDK.Utils;
@@ -7,10 +8,6 @@ namespace Riskified.SDK.Model.OrderElements
 {
     public class CreditCardPaymentDetails : IPaymentDetails
     {
-        public enum _type
-        {
-            credit_card, paypal
-        }
 
         /// <summary>
         /// The payment information for the order
@@ -96,7 +93,11 @@ public void Validate(Validations validationType = Validations.Weak)
         public string Mid { get; set; }
 
         [JsonProperty(PropertyName = "_type")]
-        public _type Type { get; set; }
+        [JsonConverter(typeof(StringEnumConverter))]
+        public PaymentDetailsType Type 
+        {
+            get { return PaymentDetailsType.credit_card; }
+        }
 
         [JsonProperty(PropertyName = "authentication_result")]
         public AuthenticationResult AuthenticationResult { get; set; }

diff --git a/Riskified.SDK/Model/OrderElements/PaymentDetailsType.cs b/Riskified.SDK/Model/OrderElements/PaymentDetailsType.cs
@@ -0,0 +1,7 @@
+namespace Riskified.SDK.Model.OrderElements
+{
+    public enum PaymentDetailsType
+    {
+        credit_card, paypal
+    }
+}
diff --git a/Riskified.SDK/Model/OrderElements/PaypalPaymentDetails.cs b/Riskified.SDK/Model/OrderElements/PaypalPaymentDetails.cs
@@ -1,4 +1,5 @@
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Riskified.SDK.Exceptions;
 using Riskified.SDK.Model.OrderCheckoutElements;
 using Riskified.SDK.Utils;
@@ -69,5 +70,11 @@ public void Validate(Validations validationType = Validations.Weak)
         [JsonProperty(PropertyName = "authentication_result")]
         public AuthenticationResult AuthenticationResult { get; set; }
 
+        [JsonProperty(PropertyName = "_type")]
+        [JsonConverter(typeof(StringEnumConverter))]
+        public PaymentDetailsType Type
+        {
+            get { return PaymentDetailsType.paypal; }
+        }
     }
 }
diff --git a/Riskified.SDK/Riskified.SDK.csproj b/Riskified.SDK/Riskified.SDK.csproj
@@ -74,6 +74,7 @@
     <Compile Include="Model\OrderElements\IPaymentDetails.cs" />
     <Compile Include="Model\OrderElements\NoChargeDetails.cs" />
     <Compile Include="Model\OrderElements\Passenger.cs" />
+    <Compile Include="Model\OrderElements\PaymentDetailsType.cs" />
     <Compile Include="Model\OrderElements\PaypalPaymentDetails.cs" />
     <Compile Include="Model\OrderElements\ProductType.cs" />
     <Compile Include="Model\OrderElements\Recipient.cs" />
@@ -143,9 +144,7 @@
   <ItemGroup>
     <None Include="packages.config" />
   </ItemGroup>
-  <ItemGroup>
-    <Folder Include="Model\AccountActionElements\" />
-  </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.
@@ -154,4 +153,4 @@
   <Target Name="AfterBuild">
   </Target>
   -->
-</Project>
+</Project>