don't send box id if tabsetpanel id is null in tabBox

RinteRface · May 26, 2021 · fec6eb9 · fec6eb9
1 parent eae7be5
commit fec6eb9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/R/cards.R b/R/cards.R
@@ -1066,7 +1066,7 @@ bs4InfoBox <- function(title, value = NULL, subtitle = NULL, icon = shiny::icon(
 #' @family cards
 #' @rdname tabBox
 #'
-#' @note User will access the \link{tabBox} input with input$<tabset_id>_box. This allows
+#' @note User will access the \link{tabBox} input with input$<id>_box. This allows
 #' to get the state of the box and update it on the server with \link{updateBox}.
 #'
 #' @examples
@@ -1223,8 +1223,8 @@ bs4TabCard <- function(..., id = NULL, selected = NULL, title = NULL, width = 6,
   }
 
   # add custom input id. User will access the tabBox input with input$<tabset_id>_box
-  boxTag$children[[1]]$attribs$id <- paste0(id, "_box")
-  boxTag$children[[2]]$attribs$`data-for` <- paste0(id, "_box")
+  boxTag$children[[1]]$attribs$id <- if (!is.null(id)) paste0(id, "_box")
+  boxTag$children[[2]]$attribs$`data-for` <- if (!is.null(id)) paste0(id, "_box")
   boxTag
 }
 

diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -8,5 +8,5 @@ articles:
   improved-boxes: improved-boxes.html
   more-skins: more-skins.html
   step-by-step: step-by-step.html
-last_built: 2021-05-26T12:12Z
+last_built: 2021-05-26T12:58Z
 
diff --git a/docs/reference/tabBox.html b/docs/reference/tabBox.html
diff --git a/man/tabBox.Rd b/man/tabBox.Rd